Hygiene B4d: PlayerResolve dedup + explicit Temp-ECB Dispose tail

- New Server/PlayerResolve.TryResolve single-sources the RPC
  SourceConnection -> NetworkId -> conn->player map resolve (3 sites:
  ClassSelectReceive, PrepPurchase, DebugCommandReceive); EntityManager
  reads keep it source-gen-safe from Bursted receivers.
- ecb.Dispose() after Playback in 9 Temp-ECB systems (explicit-lifetime
  hygiene).
- The TuningConfig.GetOrDefault(ref state) variant of this tail was
  REVERTED: state.GetEntityQuery in OnUpdate trips the Entities
  "creates a query during OnUpdate" diagnostic per system per world
  (caught in Play smoke) - the SystemAPI.TryGetSingleton idiom is
  already source-gen-optimal, confirming the original B4 deferral.

Verified: 466/466 EditMode green on the final tree, console clean,
Play smoke 0 errors.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

This commit is contained in:

Luis Gonzalez

2026-07-09 12:39:55 -07:00

parent 21a4c71413

commit 813c829420

14 changed files with 41 additions and 6 deletions

									
										Assets/_Project/Scripts/Server/HomeBase/SharedStorageSpawnSystem.cs
									
		+1
		
												View File
												
				@@ -55,6 +55,7 @@ namespace ProjectM.Server

				            ecb.DestroyEntity(spawnerEntity);

				            ecb.Playback(state.EntityManager);

				            ecb.Dispose();

				        }

				    }

				}