DR-042 Phase A: expedition-driven win — move win-driver off base-siege survival, kill the AFK path

Design-review-gated (wf_ebef4e81-dba, GREEN-WITH-CHANGES). The win-driver moves
from "survive N base sieges" to "clear N expeditions". The review overturned the
literal plan: credit on RETURN, not at the clear edge (clear-edge crediting arms
the undefended final base siege -> uncontestable terminal Loss).

- ExpeditionGateSystem: now the sole production writer of GoalProgress.Charge —
  a clamped +1 per cleared expedition folded into the existing once-per-epoch
  reward block, reusing the LastRewardedEpoch latch (Ore + Charge share fate) +
  a SaveRequest checkpoint. No new latch, no new GhostField, no ordering change.
- CyclePhaseSystem: deleted the survived-siege +1 (the AFK win path). Victory
  latch unchanged; GoalReached still arms the final base siege at cap.
- CycleDirectorAuthoring + CycleDirector.prefab: ScheduleEnabled baked OFF
  (retaliation-only). A serialized prefab bool ignores the C# field initializer,
  so the value is flipped in the prefab, not just the code default.
- Tests: re-pointed CyclePhaseSystemTests + EndgameWinLoseTests survived-siege
  assertions; extended ExpeditionGateRewardTests (+1, no-double-credit, clamp).
  389/389 EditMode green; clean netcode Play smoke (no sort-cycle, Schedule=0).

SaveData stays v5. Docs: DR-042 build record + forks resolved, CLAUDE.md
base-loop line, Backlog (A done).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Assets/_Project/Scripts/Server/World/CyclePhaseSystem.cs

@@ -159,18 +159,12 @@ namespace ProjectM.Server
                         if (SystemAPI.HasComponent<SaveRequest>(cycleEntity))
                             SystemAPI.SetComponent(cycleEntity, new SaveRequest { Pending = 1 });
                     }
-                    else if (SystemAPI.HasComponent<GoalProgress>(cycleEntity))
-                    {
-                        // Long-arc goal: +1 per siege survived, CLAMPED to Target (single writer). Clamping at the
-                        // increment site keeps the persisted Charge bounded regardless of system order; GoalReachedSystem
-                        // only READS this edge to arm the final siege.
-                        var goal = SystemAPI.GetComponent<GoalProgress>(cycleEntity);
-                        goal.Charge = math.min(goal.Charge + 1, goal.Target);
-                        SystemAPI.SetComponent(cycleEntity, goal);
-                        // Autosave checkpoint: a survived siege is a natural save point (host-only writer consumes the flag).
-                        if (SystemAPI.HasComponent<SaveRequest>(cycleEntity))
-                            SystemAPI.SetComponent(cycleEntity, new SaveRequest { Pending = 1 });
-                    }
+                    // DR-042: a SURVIVED base siege no longer advances the win meter — that was the AFK/passive win
+                    // path (scheduled sieges auto-armed + auto-collapsed on timeout, so standing still won). The win-
+                    // driver moved to EXPEDITION CLEARS: GoalProgress.Charge is now credited per cleared expedition by
+                    // ExpeditionGateSystem on the player's RETURN. Surviving a normal siege is still its own reward
+                    // (resources kept, Core intact) but is not progress toward Victory. The final-siege Victory latch
+                    // above is unchanged — GoalReachedSystem still arms the climactic final siege once Charge hits Target.
                 }
             }