Hygiene B3: single-sourcing & magic-number consolidation

- StructureCatalogAuthoring: WallCostOre -> WallCostBiomass (it bakes a Biomass cost; [FormerlySerializedAs] preserves the scene value).
- Harvester/Fabricator authoring: resource-id byte defaults reference ResourceId.Ore/.Charge instead of magic 2/4.
- RegionMath.RegionBoundaryX (= ExpeditionOffsetX*0.5) single-sources the region-flip X used by HudSystem + OnboardingSystem (was 500f in 3 places).
- CharacterComponent.DefaultGroundedSharpness single-sources the CC sharpness 15f (GetDefault, DashSystem, PlayerDeathStateSystem, PlayerCharacterAuthoring).
- InventorySlot [InternalBufferCapacity] references Tuning.InventoryMaxSlots.
- ConnectionMode enum -> byte-const class (project convention; removes the latent enum-in-Burst trap); field + one Seed() param become byte.
- Tuning.ChargerWindupTicks single-sources the Charger telegraph windup (EnemyBaker + TuningConfig.Defaults; was a bare 30 that could drift).
- (TicksPerSecond deliberately NOT added: no seconds->ticks conversion site exists; the tick-count fields are per-authoring designer tunables, so a const would be unreferenced.)

451/451 EditMode tests pass.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

This commit is contained in:

Luis Gonzalez

2026-07-07 23:29:43 -07:00

parent 589e712db3

commit ba303e5fd0

16 changed files with 37 additions and 21 deletions

									
										Assets/_Project/Scripts/Client/UI/WorldLauncher.cs
									
		+1
		-1
	
												View File
												
				@@ -102,7 +102,7 @@ namespace ProjectM.Client

				            Busy = false;

				        }

				        static void Seed(World world, ConnectionMode mode, string address, ushort port)

				        static void Seed(World world, byte mode, string address, ushort port)

				        {

				            if (world is not { IsCreated: true }) return;

				            var em = world.EntityManager;