kronic/Project-M
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Docs: LANTERN Phase 1 combat review-hardened — Build Spec + DR-050

Browse Source 
Adversarial pre-code review (wf_c7575828-934; 23 agents, 0 failures) over the Phase 1
combat-gym design raised 19 findings (8 CONFIRMED + 11 PARTIAL, 0 refuted) and caught
design-breakers before code:
- SpawnId bit budget exhausted (owner16|fireCount12|fork4) -> repack owner14|socket2|
  fireCount12|fork4 so 4 sockets don't collide/desync.
- "KEEP as-is" client feel layer is a real migration (CombatFeedback/PlayerAnimationDrive/
  HUD read the reworked AbilityRef/AbilityCooldown) + needs a new replicated class signal.
- predict-spawn is Projectile-only (Aoe/Hitscan/decoy = Cone-precedent server-only spawn);
  Blink = velocity-blink in its own system (not a transform teleport); SocketCooldown hot
  not cold; EffectiveAbilityStats 4-wide; windup needs a rollback-safe resolve tick;
  Harpooner reel + player zone = new server-only code, not salvage.

Verdict: pass-with-changes on all 3 lenses, no redesign. Phase1_Combat_Gym_Build_Spec =
the implementation contract (8-step build order, wire/bake churn, open risks, ledger).
DR-050 records it; pre-review design -> superseded.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Luis Gonzalez
2026-07-14 08:57:11 -07:00
parent 831c41c711
commit 6474e8faff
5 changed files with 345 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Docs/Vault/00_Home/Home.md
+1 -1
View File
@@ -21,7 +21,7 @@ Multiplayer game on **Unity DOTS** (Entities) + **Netcode for Entities** (server
- **Game Design** → [[Systems_Index]] — per-system design docs
- **Roadmap** → **[[Roadmap_Lantern_Slice]]** (operative) · [[Lantern_Strip_Mothball_Inventory]] (salvage map) · [[Lantern_World_Model_Spike]] (★review-first) · [[Backlog]] / [[Path_to_Fun]] / [[Milestones]] / [[Iteration_2026-07_CoopHades]] (history).
- **Sessions** → `07_Sessions/2026/` — dated work logs (latest: [[2026-07-13_Lantern_Phase0_Design_Pass_B]] · [[2026-07-13_Lantern_Phase0_Adoption_Pivot]])
- **Decisions** → `07_Sessions/_Decisions/` — decision records DR-001 … DR-049 · [[DR-001_Netcode_Test_Harness]] · latest [[DR-049_Lantern_World_Model_Design]] (world-model, review-hardened) · [[DR-048_Lantern_Adoption_Full_Pivot]] (the pivot)
- **Decisions** → `07_Sessions/_Decisions/` — decision records DR-001 … DR-050 · [[DR-001_Netcode_Test_Harness]] · latest [[DR-050_Lantern_Phase1_Combat_Design]] (Phase 1 combat, review-hardened) · [[DR-049_Lantern_World_Model_Design]] · [[DR-048_Lantern_Adoption_Full_Pivot]]
- **Meta** → [[Documentation_Protocol]] · [[Tags]]
- **Templates** → [[Session_Log_Template]] · [[Decision_Record_Template]]