Hygiene B2: dead-code removal

Delete (unreferenced in any scene, per operator decision): - TrainingDummy* chain (authoring/spawner/system/components/prefab) + UpgradePickup* chain (authoring/spawner/systems/components/prefab); remove TrainingDummyTag from the 3 live combat queries (AbilityFire/Melee/HealthApplyDamage now key on EnemyTag) and repoint HealthApplyDamageSystemTests to EnemyTag. - Dead RPC RegionTransitSystem + RegionTransitRequest (no sender, ungated) + its test. - Heartbeat + HeartbeatSystem (no WorldSystemFilter, ran no-op every tick) + its test. - BuildSendSystem dead conveyor/pylon dev hooks (s_ConveyorDir, [/] rotation, Place{Pylon,Harvester,Conveyor} statics). - Deprecated CyclePhase alias consts (Expedition/Defend/Build/*Ticks); repoint WaveSystemTests to Siege/Calm. - Unread FeelConfig fields (HitFlashDurationMs, RumbleHeavy) + dangling HudUi doc-comments + stale crefs. 451/451 EditMode tests pass. CLAUDE.md HeartbeatSystemTests example ref to be repointed in B7. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-07 23:16:53 -07:00
parent b1041003f0
commit 589e712db3
53 changed files with 28 additions and 1229 deletions
@@ -1,71 +0,0 @@
-using ProjectM.Simulation;
-using Unity.Burst;
-using Unity.Collections;
-using Unity.Entities;
-using Unity.NetCode;
-using Unity.Transforms;
-
-namespace ProjectM.Server
-{
-    /// <summary>
-    /// Server-authoritative handler for <see cref="RegionTransitRequest"/> RPCs. Resolves the sender's player
-    /// (via the source connection's <see cref="NetworkId"/> -&gt; <see cref="GhostOwner"/>), flips its
-    /// <see cref="RegionTag"/> to the requested region, and teleports it to that region's origin
-    /// (<see cref="RegionMath.RegionOrigin"/>, centered on the base via <see cref="BaseGridMath.PlotCenter"/>).
-    /// Runs in the default server SimulationSystemGroup (NOT the prediction loop) so the transit applies once;
-    /// the next snapshot reconciles the owner-predicted client and <see cref="RegionRelevancySystem"/> re-scopes
-    /// which region's ghosts the connection receives. Mirrors the <see cref="StorageOpReceiveSystem"/> RPC shape.
-    /// </summary>
-    [BurstCompile]
-    [WorldSystemFilter(WorldSystemFilterFlags.ServerSimulation)]
-    public partial struct RegionTransitSystem : ISystem
-    {
-        [BurstCompile]
-        public void OnCreate(ref SystemState state)
-        {
-            state.RequireForUpdate<BaseAnchor>();
-
-            var builder = new EntityQueryBuilder(Allocator.Temp)
-                .WithAll<RegionTransitRequest, ReceiveRpcCommandRequest>();
-            state.RequireForUpdate(state.GetEntityQuery(builder));
-        }
-
-        [BurstCompile]
-        public void OnUpdate(ref SystemState state)
-        {
-            var baseCenter = BaseGridMath.PlotCenter(SystemAPI.GetSingleton<BaseAnchor>());
-
-            // Map connection NetworkId -> player entity.
-            var playerByConn = new NativeHashMap<int, Entity>(8, Allocator.Temp);
-            foreach (var (owner, entity) in
-                     SystemAPI.Query<RefRO<GhostOwner>>().WithAll<PlayerTag, RegionTag>().WithEntityAccess())
-            {
-                playerByConn[owner.ValueRO.NetworkId] = entity;
-            }
-
-            var ecb = new EntityCommandBuffer(Allocator.Temp);
-
-            foreach (var (request, receive, requestEntity) in
-                     SystemAPI.Query<RefRO<RegionTransitRequest>, RefRO<ReceiveRpcCommandRequest>>().WithEntityAccess())
-            {
-                var connEntity = receive.ValueRO.SourceConnection;
-                if (SystemAPI.HasComponent<NetworkId>(connEntity))
-                {
-                    int connId = SystemAPI.GetComponent<NetworkId>(connEntity).Value;
-                    if (playerByConn.TryGetValue(connId, out var player))
-                    {
-                        byte target = request.ValueRO.TargetRegion;
-                        SystemAPI.GetComponentRW<RegionTag>(player).ValueRW.Region = target;
-                        SystemAPI.GetComponentRW<LocalTransform>(player).ValueRW.Position =
-                            RegionMath.RegionOrigin(target, baseCenter);
-                    }
-                }
-
-                ecb.DestroyEntity(requestEntity);
-            }
-
-            ecb.Playback(state.EntityManager);
-            playerByConn.Dispose();
-        }
-    }
-}
@@ -1,2 +0,0 @@
-fileFormatVersion: 2
-guid: 44d6ce89f189d984c83cd213d86d4b02